linux-ext4 - Re: [ext4:dev 47/50] fs/ext4/indirect.c:1799 ext4_ind_punch_hole() warn: inconsistent returns mutex:&inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120928132055.GC13352@thunk.org>
Date:	Fri, 28 Sep 2012 09:20:55 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Zheng Liu <wenqing.lz@...bao.com>, kernel-janitors@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [ext4:dev 47/50] fs/ext4/indirect.c:1799 ext4_ind_punch_hole()
 warn: inconsistent returns mutex:&inode->i_mutex: locked (1710) unlocked
 (1799)

On Fri, Sep 28, 2012 at 02:07:19PM +0800, Fengguang Wu wrote:
> Hi Zheng,
> 
> FYI, there are new smatch warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head:   b2f1a8e5612e2488a3995ec06b422b44651d088b
> commit: 3e1b02687146ddefa8e53c2a5e13d3bd87b16b09 [47/50] ext4: add support for hole punching non-extent-mapped files

I'm going to be dropping the indirect punch hole patches from the ext4
dev tree, based on the number of xfstests failures that I found in my
overnight testing.

I had hoped the changes were small and localized, and wouldn't cause
problems if the punch hole feature wasn't used, but at this point,
given that many distributions are starting to use the ext4 file system
for legacy ext3 file systems, my judgement is that the risks are too
great for the upcoming merge window; so this will probably need to
wait for the next development cycle.

     	     	  	  				- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html