lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 29 Sep 2012 15:43:48 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, jack@...e.cz, lczerner@...hat.com
Subject: Re: [PATCH 07/11] ext4: serialize unlocked dio reads with truncate

On Sat, 29 Sep 2012 00:49:04 -0400, "Theodore Ts'o" <tytso@....edu> wrote:
> On Fri, Sep 28, 2012 at 07:44:07PM +0400, Dmitry Monakhov wrote:
> >  	if (attr->ia_valid & ATTR_SIZE) {
> > -		if (attr->ia_size != i_size_read(inode))
> > +		if (attr->ia_size != inode->i_size) {
> 
> Why this change?   Why are you not using i_size_read() here?
Since we hold i_mutex no one is able to change i_size, and it
is safe to access it directly.
> 
>     	 	       	       	   - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists