linux-ext4 - Re: metadata_csum + unclean shutdown = failure to boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121008031704.17730.qmail@science.horizon.com>
Date:	7 Oct 2012 23:17:04 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	linux@...izon.com, tytso@....edu
Cc:	linux-ext4@...r.kernel.org, tm@....ma
Subject: Re: metadata_csum + unclean shutdown = failure to boot

I'm testing that patch, but you may want to fix it a bit more before submitting to
stable@...
fs/ext4/resize.c: In function 'update_backups':
fs/ext4/resize.c:973:39: error: too many arguments to function 'ext4_superblock_csum_set'
In file included from fs/ext4/ext4_jbd2.h:20:0,
                 from fs/ext4/resize.c:17:
fs/ext4/ext4.h:2049:13: note: declared here

The fix is of course obvious and I'm compiling it now.

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 41f6ef6..e781259 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -970,7 +970,7 @@ static void update_backups(struct super_block *sb,
 		goto exit_err;
 	}
 
-	ext4_superblock_csum_set(sb, (struct ext4_super_block *)data);
+	ext4_superblock_csum_set(sb);
 
 	while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
 		struct buffer_head *bh;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html