linux-ext4 - [PATCH] ext4: fix error handling in ext4_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1349694582-16958-1-git-send-email-eugene.shatokhin@rosalab.ru>
Date:	Mon,  8 Oct 2012 15:09:42 +0400
From:	Eugene Shatokhin <eugene.shatokhin@...alab.ru>
To:	linux-ext4@...r.kernel.org
Cc:	Eugene Shatokhin <eugene.shatokhin@...alab.ru>
Subject: [PATCH] ext4: fix error handling in ext4_fill_super()

If ext4_mb_init() returns error (e.g. if there is not enough memory),
ext4_fill_super() returns 0 rather than the error code.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=48431

The patch fixes that problem.

Signed-off-by: Eugene Shatokhin <eugene.shatokhin@...alab.ru>
---
 fs/ext4/super.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 982f6fc..7292532 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3982,6 +3982,7 @@ no_journal:
 	if (err) {
 		ext4_msg(sb, KERN_ERR, "failed to initialize mballoc (%d)",
 			 err);
+		ret = err;
 		goto failed_mount5;
 	}
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html