linux-ext4 - Re: [PATCH] ext3: fix return values on parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3v0cf65.fsf@xmission.com>
Date:	Mon, 08 Oct 2012 23:50:26 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Zhao Hongjiang <zhaohongjiang37@...il.com>, jack@...e.cz,
	akpm@...ux-foundation.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	serge.hallyn@...onical.com, containers@...ts.linux-foundation.org
Subject: Re: [PATCH] ext3: fix return values on parse_options() failure

Lukáš Czerner <lczerner@...hat.com> writes:

> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
>
>> Date: Tue, 09 Oct 2012 13:48:47 +0800
>> From: Zhao Hongjiang <zhaohongjiang37@...il.com>
>> To: jack@...e.cz
>> Cc: akpm@...ux-foundation.org, adilger.kernel@...ger.ca,
>>     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
>>     Eric W. Biederman <ebiederm@...ssion.com>, serge.hallyn@...onical.com,
>>     containers@...ts.linux-foundation.org
>> Subject: [PATCH] ext3: fix return values on parse_options() failure
>> 
>> From: Zhao Hongjiang <zhaohongjiang@...wei.com>
>> 
>> parse_options() in ext3 should return 0 when parse the mount options fails.
>> 
>
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
>
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Ugh.  I goofed that up.  How annoying that ext4 is different than ext3
and ext2 in this regard.

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html