linux-ext4 - Re: [PATCH 1/2] Use 'inode' variable that is already dereferenced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121016022803.GA5155@gmail.com>
Date:	Tue, 16 Oct 2012 10:28:03 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Anatol Pomozov <anatol.pomozov@...il.com>
Cc:	tytso@....edu, wenqing.lz@...bao.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] Use 'inode' variable that is already dereferenced

On Mon, Oct 15, 2012 at 12:06:48PM -0700, Anatol Pomozov wrote:
> Tested: xfs tests
> 
> Signed-off-by: Anatol Pomozov <anatol.pomozov@...il.com>
> ---
>  fs/ext4/page-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
> index 68e896e..0fd16e6 100644
> --- a/fs/ext4/page-io.c
> +++ b/fs/ext4/page-io.c
> @@ -111,7 +111,7 @@ static int ext4_end_io(ext4_io_end_t *io)
>  		inode_dio_done(inode);
>  	/* Wake up anyone waiting on unwritten extent conversion */
>  	if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten))
> -		wake_up_all(ext4_ioend_wq(io->inode));
> +		wake_up_all(ext4_ioend_wq(inode));

Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html