linux-ext4 - Re: [PATCH] ext4: add hot tracking support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEH94LjZtT-Nh-6AqUaPCSwrbkLmz-BuO8D=9FjeE=_xqGmJzA@mail.gmail.com>
Date:	Mon, 29 Oct 2012 10:24:50 +0800
From:	Zhi Yong Wu <zwu.kernel@...il.com>
To:	Zhi Yong Wu <zwu.kernel@...il.com>, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org, cmm@...ibm.com,
	wuzhy@...ux.vnet.ibm.com, Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH] ext4: add hot tracking support

On Mon, Oct 29, 2012 at 10:32 AM, Zheng Liu <gnehzuil.liu@...il.com> wrote:
> On Sun, Oct 28, 2012 at 09:45:49PM +0800, Zhi Yong Wu wrote:
> [snip]
>> On Sun, Oct 28, 2012 at 5:22 PM, Zheng Liu <gnehzuil.liu@...il.com> wrote:
>> > @@ -864,6 +865,8 @@ static void ext4_put_super(struct super_block *sb)
>> >         ext4_ext_release(sb);
>> >         ext4_xattr_put_super(sb);
>> >
>> > +       if (sbi->s_hottrack_enable)
>> > +               hot_track_exit(sb);
>> >         if (!(sb->s_flags & MS_RDONLY)) {
>> >                 EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
>> >                 es->s_state = cpu_to_le16(sbi->s_mount_state);
>> HI, Zheng,
>>
>> Do you not need to free stuff related to hot tracking when umount?
>
> I call hot_track_exit() in put_super callback function.  I have no idea
> that there still has some other functions that need to be called.  Am I
> missing something?
You are right....
>
> Regards,
> Zheng



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html