linux-ext4 - Re: [PATCH] ext4: remove ext4_handle_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121031122712.GA26151@andromeda.usersys.redhat.com>
Date:	Wed, 31 Oct 2012 10:27:12 -0200
From:	Carlos Maiolino <cmaiolino@...hat.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: remove ext4_handle_release_buffer()

On Tue, Oct 30, 2012 at 12:05:10PM -0500, Eric Sandeen wrote:
> ext4_handle_release_buffer() was intended to remove journal
> write access from a buffer, but it doesn't actually do anything
> at all other than add a BUFFER_TRACE point, but it's not reliably
> used for that either.  Remove all the associated dead code.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> If this flies, I can do the same for ext3.
> 
> diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
> index 56d258c..7177f9b 100644
> --- a/fs/ext4/ext4_jbd2.h
> +++ b/fs/ext4/ext4_jbd2.h
> @@ -254,13 +254,6 @@ static inline void ext4_handle_sync(handle_t *handle)
>  		handle->h_sync = 1;
>  }
>  

Particularly, I like code clean up, and the patch looks good

Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>

-- 
--Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html