linux-ext4 - Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5092F67A.2060203@panasas.com>
Date:	Thu, 1 Nov 2012 15:23:54 -0700
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Jeff Layton <jlayton@...ba.org>
CC:	"Darrick J. Wong" <darrick.wong@...cle.com>, <axboe@...nel.dk>,
	<lucho@...kov.net>, <tytso@....edu>, <sage@...tank.com>,
	<ericvh@...il.com>, <mfasheh@...e.com>, <dedekind1@...il.com>,
	<adrian.hunter@...el.com>, <dhowells@...hat.com>,
	<sfrench@...ba.org>, <jlbec@...lplan.org>, <rminnich@...dia.gov>,
	<linux-cifs@...r.kernel.org>, <jack@...e.cz>,
	<martin.petersen@...cle.com>, <neilb@...e.de>,
	<david@...morbit.com>, <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-mtd@...ts.infradead.org>,
	<linux-fsdevel@...r.kernel.org>,
	<v9fs-developer@...ts.sourceforge.net>,
	<ceph-devel@...r.kernel.org>, <linux-ext4@...r.kernel.org>,
	<linux-afs@...ts.infradead.org>, <ocfs2-devel@....oracle.com>
Subject: Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable
 page writeback

On 11/01/2012 01:22 PM, Jeff Layton wrote:
> Hmm...I don't know...
> 
> I've never been crazy about using the page lock for this, but in the
> absence of a better way to guarantee stable pages, it was what I ended
> up with at the time. cifs_writepages will hold the page lock until
> kernel_sendmsg returns. At that point the TCP layer will have copied
> off the page data so it's safe to release it.
> 
> With this change though, we're going to end up blocking until the
> writeback flag clears, right? And I think that will happen when the
> reply comes in? So, we'll end up blocking for much longer than is
> really necessary in page_mkwrite with this change.
> 

Hmm OK, that is a very good point. In that case it is just a simple
nack on Darrick's hunk to cifs. cifs is fine and should not be touched

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html