linux-ext4 - Re: [RFC v4+ hot_track 05/19] vfs: add hooks to enable hot tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Nov 2012 23:51:36 +0100
From:	David Sterba <dave@...os.cz>
To:	zwu.kernel@...il.com
Cc:	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxram@...ux.vnet.ibm.com, viro@...iv.linux.org.uk,
	david@...morbit.com, tytso@....edu, cmm@...ibm.com,
	wuzhy@...ux.vnet.ibm.com, wenqing.lz@...bao.com
Subject: Re: [RFC v4+ hot_track 05/19] vfs: add hooks to enable hot tracking

On Mon, Oct 29, 2012 at 12:30:47PM +0800, zwu.kernel@...il.com wrote:
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -19,6 +19,7 @@
>  #include <linux/pagemap.h>
>  #include <linux/syscalls.h>
>  #include <linux/file.h>
> +#include <linux/hot_tracking.h>
>  
>  /*
>   * Initialise a struct file's readahead state.  Assumes that the caller has
> @@ -138,6 +139,11 @@ static int read_pages(struct address_space *mapping, struct file *filp,
>  out:
>  	blk_finish_plug(&plug);
>  
> +	/* Hot data tracking */
> +	hot_update_freqs(mapping->host, (u64)(list_entry(pages->prev,\
> +				struct page, lru)->index) << PAGE_CACHE_SHIFT,
> +			(u64)nr_pages * PAGE_CACHE_SIZE, 0);

There's a stale \ at the end of the line, and I find this formatting
hard to read. Does the following look acceptable?

	hot_update_freqs(mapping->host,
		(u64)(list_entry(pages->prev, struct page, lru)->index)
			<< PAGE_CACHE_SHIFT,
		(u64)nr_pages * PAGE_CACHE_SIZE, 0);

> +
>  	return ret;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html