lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121112141258.GA2496@andromeda.usersys.redhat.com> Date: Mon, 12 Nov 2012 12:12:58 -0200 From: Carlos Maiolino <cmaiolino@...hat.com> To: Eric Sandeen <sandeen@...hat.com> Cc: ext4 development <linux-ext4@...r.kernel.org> Subject: Re: [PATCH V2] ext4: init pagevec in ext4_da_block_invalidatepages On Sun, Nov 11, 2012 at 03:50:37PM -0600, Eric Sandeen wrote: > ext4_da_block_invalidatepages is missing a pagevec_init(), > which means that pvec->cold contains random garbage. > > This affects whether the page goes to the front or > back of the LRU when ->cold makes it to > free_hot_cold_page() > > Signed-off-by: Eric Sandeen <sandeen@...hat.com> > Cc: stable@...r.kernel.org > --- > > (resend w/ stable in S-O-B area rather than fat-fingered > in email cc :/ ) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index b3c243b..f89c0e5 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -1503,6 +1503,8 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd) > > index = mpd->first_page; > end = mpd->next_page - 1; > + > + pagevec_init(&pvec, 0); > while (index <= end) { > nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); > if (nr_pages == 0) > Looks Good, Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com> -- Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists