lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 21 Nov 2012 11:35:15 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Zheng Liu <gnehzuil.liu@...il.com>
cc:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org,
	tytso@....edu, dmonakhov@...nvz.org, bergwolf@...il.com
Subject: Re: [PATCH 1/2] ext4: Prevent race while walking extent tree

On Wed, 21 Nov 2012, Zheng Liu wrote:

> Date: Wed, 21 Nov 2012 14:55:42 +0800
> From: Zheng Liu <gnehzuil.liu@...il.com>
> To: Lukas Czerner <lczerner@...hat.com>
> Cc: linux-ext4@...r.kernel.org, tytso@....edu, dmonakhov@...nvz.org,
>     bergwolf@...il.com
> Subject: Re: [PATCH 1/2] ext4: Prevent race while walking extent tree
> 
> On Tue, Nov 20, 2012 at 03:57:39PM +0100, Lukas Czerner wrote:
> [cut]
> > +
> >  int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> >  		__u64 start, __u64 len)
> >  {
> > @@ -4802,8 +4811,8 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> >  		 * Walk the extent tree gathering extent information.
> >  		 * ext4_ext_fiemap_cb will push extents back to user.
> >  		 */
> 
> This comment needs to be updated because ext4_ext_fiemap_cb has been
> renamed.
> 
> Regards,
>                                                 - Zheng

Good catch, I'll resend it.

Thanks!
-Lukas

> 
> > -		error = ext4_ext_walk_space(inode, start_blk, len_blks,
> > -					  ext4_ext_fiemap_cb, fieinfo);
> > +		error = ext4_fill_fiemap_extents(inode, start_blk,
> > +						 len_blks, fieinfo);
> >  	}
> >  
> >  	return error;
> > -- 
> > 1.7.7.6
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists