linux-ext4 - Re: [PATCH 4/4] ext4: remove redundant initialization in ext4_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Nov 2012 14:37:56 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Guo Chao <yan@...ux.vnet.ibm.com>
cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/4] ext4: remove redundant initialization in
 ext4_fill_super()

On Fri, 30 Nov 2012, Guo Chao wrote:

> Date: Fri, 30 Nov 2012 14:41:46 +0800
> From: Guo Chao <yan@...ux.vnet.ibm.com>
> To: tytso@....edu
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 4/4] ext4: remove redundant initialization in
>     ext4_fill_super()
> 
> We use kzalloc() to allocate sbi, no need to zero its field.
> 
> Signed-off-by: Guo Chao <yan@...ux.vnet.ibm.com>
> ---
>  fs/ext4/super.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 15d28e3..a99f6c7 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3799,7 +3799,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  
>  	INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */
>  	mutex_init(&sbi->s_orphan_lock);
> -	sbi->s_resize_flags = 0;
>  
>  	sb->s_root = NULL;
>  
> 

There are other members of sbi which we initialize to zero even
though we use kzalloc.

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html