linux-ext4 - Re: [PATCH 2/4] ext4: use sync_inode_metadata() when sync inode metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1211301423100.8688@dhcp-1-104.brq.redhat.com>
Date:	Fri, 30 Nov 2012 14:24:48 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Guo Chao <yan@...ux.vnet.ibm.com>
cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/4] ext4: use sync_inode_metadata() when sync inode
 metadata

On Fri, 30 Nov 2012, Guo Chao wrote:

> Date: Fri, 30 Nov 2012 14:41:44 +0800
> From: Guo Chao <yan@...ux.vnet.ibm.com>
> To: tytso@....edu
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 2/4] ext4: use sync_inode_metadata() when sync inode metadata
> 
> We have a dedicated interface to sync inode metadata.
> 
> Signed-off-by: Guo Chao <yan@...ux.vnet.ibm.com>
> ---
>  fs/ext4/fsync.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> index be1d89f..dfbc1fe 100644
> --- a/fs/ext4/fsync.c
> +++ b/fs/ext4/fsync.c
> @@ -44,7 +44,6 @@
>   */
>  static int ext4_sync_parent(struct inode *inode)
>  {
> -	struct writeback_control wbc;
>  	struct dentry *dentry = NULL;
>  	struct inode *next;
>  	int ret = 0;
> @@ -66,10 +65,7 @@ static int ext4_sync_parent(struct inode *inode)
>  		ret = sync_mapping_buffers(inode->i_mapping);
>  		if (ret)
>  			break;
> -		memset(&wbc, 0, sizeof(wbc));
> -		wbc.sync_mode = WB_SYNC_ALL;
> -		wbc.nr_to_write = 0;         /* only write out the inode */
> -		ret = sync_inode(inode, &wbc);
> +		ret = sync_inode_metadata(inode, 1);
>  		if (ret)
>  			break;
>  	}
> 

Makes sense.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html