linux-ext4 - Re: [PATCH] ext4: remove some unused code lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEH94Lj2DvVREkOJfbPN4eyismsjeZ+t0x=QfumDZ5p=bXk7LA@mail.gmail.com>
Date:	Mon, 3 Dec 2012 10:11:20 +0800
From:	Zhi Yong Wu <zwu.kernel@...il.com>
To:	zwu.kernel@...il.com, linux-ext4@...r.kernel.org, tytso@....edu,
	linux-kernel@...r.kernel.org,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove some unused code lines

On Sun, Dec 2, 2012 at 8:27 PM, Zheng Liu <gnehzuil.liu@...il.com> wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@...il.com wrote:
>> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
Good suggestion, thanks.
>
> Otherwise, it looks good to me.
>
> Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>
>
> Regards,
>                                                 - Zheng
>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>> ---
>>  fs/ext4/extents.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
>> index 7011ac9..43ec639 100644
>> --- a/fs/ext4/extents.c
>> +++ b/fs/ext4/extents.c
>> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>>                 struct ext4_extent *ex)
>>  {
>>       struct ext4_ext_cache *cex;
>> -     struct ext4_sb_info *sbi;
>>       int ret = 0;
>>
>>       /*
>> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>>        */
>>       spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>>       cex = &EXT4_I(inode)->i_cached_extent;
>> -     sbi = EXT4_SB(inode->i_sb);
>>
>>       /* has cache valid data? */
>>       if (cex->ec_len == 0)
>> --
>> 1.7.6.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html