linux-ext4 - Re: [ext4:dev 40/60] fs/ext4/inode.c:1953 __ext4_journalled_writepage() error: potential NULL dereference 'page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121204135602.GE22569@mwanda>
Date:	Tue, 4 Dec 2012 16:56:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Tao Ma <tm@....ma>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [ext4:dev 40/60] fs/ext4/inode.c:1953
 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs'.

On Tue, Dec 04, 2012 at 09:25:45PM +0800, Tao Ma wrote:
> Hi Dan,
> 	Thanks for the report. Can you check whether this patch
> works for you?
> 

It looks good.

Like I mentioned before Smatch doesn't understand
ext4_has_inline_data() so it still complains later on in the
function.  But it's now obvious to a human reader that there won't
be a NULL dereference.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html