linux-ext4 - Re: [ext4:dev 37/63] fs/ext4/inline.c:268:19: error: 'empty_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50C699A1.10502@tao.ma>
Date:	Tue, 11 Dec 2012 10:25:37 +0800
From:	Tao Ma <tm@....ma>
To:	kbuild test robot <fengguang.wu@...el.com>
CC:	Tao Ma <boyu.mt@...bao.com>, linux-ext4@...r.kernel.org,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [ext4:dev 37/63] fs/ext4/inline.c:268:19: error: 'empty_zero_page'
 undeclared

On 12/11/2012 06:02 AM, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head:   9a4c8019471386c6fb039ae9e30f5216b6b55a9e
> commit: 67cf5b09a46f72e048501b84996f2f77bc42e947 [37/63] ext4: add the basic function for inline data support
> config: make ARCH=sparc allyesconfig
> 
> All error/warnings:
> 
> fs/ext4/inline.c: In function 'ext4_create_inline_data':
> fs/ext4/inline.c:268:19: error: 'empty_zero_page' undeclared (first use in this function)
> fs/ext4/inline.c:268:19: note: each undeclared identifier is reported only once for each function it appears in
> fs/ext4/inline.c: At top level:
> fs/ext4/inline.c:164:12: warning: 'ext4_read_inline_data' defined but not used [-Wunused-function]
uh, in sparc, we don't have empty_zero_page? I just want to create an
inline data file without allocating a buffer with the specified length.
So maybe I have to do the kzalloc thing then. :(

Thanks
Tao
> 
> vim +268 +/empty_zero_page fs/ext4/inline.c
> 
> 67cf5b09 Tao Ma 2012-12-10  262  
> 67cf5b09 Tao Ma 2012-12-10  263  	error = ext4_journal_get_write_access(handle, is.iloc.bh);
> 67cf5b09 Tao Ma 2012-12-10  264  	if (error)
> 67cf5b09 Tao Ma 2012-12-10  265  		goto out;
> 67cf5b09 Tao Ma 2012-12-10  266  
> 67cf5b09 Tao Ma 2012-12-10  267  	if (len > EXT4_MIN_INLINE_DATA_SIZE) {
> 67cf5b09 Tao Ma 2012-12-10 @268  		value = (void *)empty_zero_page;
> 67cf5b09 Tao Ma 2012-12-10  269  		len -= EXT4_MIN_INLINE_DATA_SIZE;
> 67cf5b09 Tao Ma 2012-12-10  270  	} else {
> 67cf5b09 Tao Ma 2012-12-10  271  		value = "";
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Center
> Fengguang Wu, Yuanhan Liu                              Intel Corporation
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html