linux-ext4 - Re: [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121218174811.GC5987@quack.suse.cz>
Date:	Tue, 18 Dec 2012 18:48:11 +0100
From:	Jan Kara <jack@...e.cz>
To:	Guo Chao <yan@...ux.vnet.ibm.com>
Cc:	akpm@...ux-foundation.org, Jan Kara <jack@...e.cz>,
	Theodore Ts'o <tytso@....edu>, Mark Fasheh <mfasheh@...e.com>,
	linux-ext4@...r.kernel.org, ocfs2-devel@....oracle.com
Subject: Re: [RFC PATCH] ext3, ext4, ocfs2: remove unused macro
 NAMEI_RA_INDEX

On Tue 18-12-12 16:56:39, Guo Chao wrote:
> This macro, initially introduced by ext2 in v0.99.15, does not
> have any users from the beginning. It has been removed in later
> ext2 version but still remains in the code of ext3, ext4, ocfs2.
> Remove this macro there.
  Thanks. I've merged the patch into my tree. Since it's trivial, I guess
other fs maintainers won't mind.

								Honza
> 
> Cc: Jan Kara <jack@...e.cz>
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: Mark Fasheh <mfasheh@...e.com>
> Cc: linux-ext4@...r.kernel.org
> Cc: ocfs2-devel@....oracle.com
> Signed-off-by: Guo Chao <yan@...ux.vnet.ibm.com>
> ---
>  fs/ext3/namei.c |    1 -
>  fs/ext4/namei.c |    1 -
>  fs/ocfs2/dir.c  |    1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index 890b894..88f64eb 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -36,7 +36,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE        (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static struct buffer_head *ext3_append(handle_t *handle,
>  					struct inode *inode,
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index cac4482..3f8c3d4 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -47,7 +47,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE	     (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static struct buffer_head *ext4_append(handle_t *handle,
>  					struct inode *inode,
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index 8fe4e28..fc12135 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -67,7 +67,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE        (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static unsigned char ocfs2_filetype_table[] = {
>  	DT_UNKNOWN, DT_REG, DT_DIR, DT_CHR, DT_BLK, DT_FIFO, DT_SOCK, DT_LNK
> -- 
> 1.7.9.5
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html