linux-ext4 - Re: [Suggestion] fs/ext3: memory leak by calling set_qf_name or clear_qf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50E66B19.5060907@asianux.com>
Date:	Fri, 04 Jan 2013 13:39:37 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Jan Kara <jack@...e.cz>
CC:	Theodore Ts'o <tytso@....edu>, akpm@...ux-foundation.org,
	linux-ext4@...r.kernel.org
Subject: Re: [Suggestion] fs/ext3: memory leak by calling set_qf_name or clear_qf_name,
 many times.

于 2012年12月31日 20:06, Jan Kara 写道:
>   Thanks for report. Yes, memory leak seems to be possible. Attached patch
> should fix it, I have added it to my tree.
> 
> 									Honza
> 

  after read your patch, today (although I am not a reviewer).
  is it a possible situation like this (just my imagination):
    1st let it call clear_qf_name successfully.
    2nd let it call set_qf_name successfully.
    3rd call clear_qf_name again ?
    ...
  if this situation is possible.
    I guess the memory still leak, after apply your patch.

  if what I guess is true
    it seems we have to duplicate memory for old_opts in ext3_remount.
    and for clear_qf_name, set_qf_name, ext3_remount:
      use normal memory allocation and free ways instead of current using.

  Regards

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html