linux-ext4 - Re: [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50EE345F.1090600@cn.fujitsu.com>
Date:	Thu, 10 Jan 2013 11:24:15 +0800
From:	Miao Xie <miaox@...fujitsu.com>
To:	dsterba@...e.cz
CC:	Linux Fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Btrfs <linux-btrfs@...r.kernel.org>,
	Linux Ext4 <linux-ext4@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Kamal Mostafa <kamal@...onical.com>,
	Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle()
 and rename them

On Fri, 28 Dec 2012 15:33:38 +0100, David Sterba wrote:
> On Thu, Dec 20, 2012 at 06:09:35PM +0800, Miao Xie wrote:
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -1314,7 +1314,6 @@ void writeback_inodes_sb_nr(struct super_block *sb,
>>  	bdi_queue_work(sb->s_bdi, &work);
>>  	wait_for_completion(&done);
>>  }
>> -EXPORT_SYMBOL(writeback_inodes_sb_nr);
> 
> Why do you remove the export? writeback_inodes_sb is exported as well.

As you said below, there is no user now.

> Originally the _nr variant has been introduced for btrfs
> (3259f8bed2f0f57c2fdcdac1b510c3fa319ef97e) and there are no other users
> now, so from that point it would make sense. From the other side, the
> change is not strictly necessary for this patch and keeps the writeback
> API a bit more flexible. I vote for keeping it.

Maybe you are right, I'll send out a new one.

> Otherwise (for the btrfs part),
> Tested-by: David Sterba <dsterba@...e.cz>

Thanks for your test and review.
Miao

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html