linux-ext4 - Re: [PATCH V2 1/2] Ext2: return ENOMEM rather than EIO if sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130115133044.GA4631@quack.suse.cz>
Date:	Tue, 15 Jan 2013 14:30:44 +0100
From:	Jan Kara <jack@...e.cz>
To:	Wang Shilong <wangshilong1991@...il.com>
Cc:	jack@...e.cz, linux-ext4@...r.kernel.org
Subject: Re: [PATCH V2 1/2] Ext2: return ENOMEM rather than EIO if
 sb_getblk fails

On Tue 15-01-13 21:19:06, Wang Shilong wrote:
> From: Wang Shilong <wangsl-fnst@...fujitsu.com>
> 
> As the only reason that sb_getblks fails is that allocation fails.
> It will be better to use ENOMEM rather than EIO.
  Thanks, I've merged the patch to my tree.

								Honza

> 
> Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
> ---
>  fs/ext2/xattr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 06209ec..2d7557d 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -665,7 +665,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh,
>  			if (unlikely(!new_bh)) {
>  				ext2_free_blocks(inode, block, 1);
>  				mark_inode_dirty(inode);
> -				error = -EIO;
> +				error = -ENOMEM;
>  				goto cleanup;
>  			}
>  			lock_buffer(new_bh);
> -- 1.7.7.6
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html