linux-ext4 - Re: [PATCH 5/5] libext2fs: avoid 32-bit overflow in ext2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130115191030.GC17719@thunk.org>
Date:	Tue, 15 Jan 2013 14:10:30 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 5/5] libext2fs: avoid 32-bit overflow in
 ext2fs_initialize with a 512M cluster size

On Tue, Jan 15, 2013 at 11:33:31PM +0800, Zheng Liu wrote:
> 
> FWIW, I wonder why we need to add such complex logical to handle a
> corner case.  I guess no one wants to use a 512MB cluster.  So changing
> max cluster size from 512MB to 256MB is very simple and straightfoward.

I agree that it seems very unlikely that there would be much interest
in using a 512MB cluster.  However, we would still need to do the
check in the case of a 16k block size (on an PowerPC or Itanium
system) at a 256MB or 128MB cluster.  So part of this check would be
needed anyway.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html