linux-ext4 - Re: [PATCH 1/3] lib/ext2fs: Add ext2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130115191714.GE17719@thunk.org>
Date:	Tue, 15 Jan 2013 14:17:14 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Darren Hart <dvhart@...radead.org>
Cc:	linux-ext4@...r.kernel.org, adilger@...ger.ca, sgw@...ux.intel.com,
	darrick.wong@...cle.com
Subject: Re: [PATCH 1/3] lib/ext2fs: Add ext2fs_symlink

On Fri, Jan 04, 2013 at 12:00:58PM -0800, Darren Hart wrote:

Applied, thanks.

> Note the one remaining FIXME. Do I need to use ext2fs_bmap2() for the
> slowlink without extents? If not, how is the 0 block associated with the
> inode?

No, you don't need to use ext2fs_bmap2().  The 0 block was set here in
the else clause:

+		if (fs->super->s_feature_incompat &
+		   EXT3_FEATURE_INCOMPAT_EXTENTS) {
+			/*
+			 * The extent bmap is setup after the inode and block
+			 * have been written out below.
+			 */
+			inode.i_flags |= EXT4_EXTENTS_FL;
+		} else {
+			inode.i_block[0] = blk;
+		}

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html