linux-ext4 - Re: [PATCH] lib/ext2fs/bitops.h: Use the optmized/documented byteswapping routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jan 2013 22:07:18 -0300
From:	Cristian Rodríguez <crrodriguez@...nsuse.org>
To:	Theodore Ts'o <tytso@....edu>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] lib/ext2fs/bitops.h: Use the optmized/documented byteswapping
 routines

On 01/14/2013 11:13 AM, Theodore Ts'o wrote:
> On Sat, Jan 12, 2013 at 04:32:25PM -0300, Cristian Rodríguez wrote:
>> In x86, it will not make much difference but other targets that
>> are not covered by the old code will be able to generate better code.
>>
>> Signed-off-by: Cristian Rodríguez <crrodriguez@...nsuse.org>
>
> The problem is that bswap_{16,32,64}() and the existence of
> <byteswap.h> is not guaranted by any standard that I'm not aware of.
> A quick Google search indicates that it's not available for the
> following platforms:
>
> 	* Mac OS X 10.5
> 	* FreeBSD 6.0
> 	* NetBSD 5.0
> 	* OpenBSD 3.8
> 	* Minix 3.1.8
> 	* AIX 5.1
> 	* HP-UX 11
> 	* IRIX 6.5
> 	* OSF/1 5.1
> 	* Solaris 11 2011-11
> 	* Cygwin
> 	* mingw
> 	* MSVC 9
> 	* Interix 3.5
> 	* BeOS
>
> So the only way we could use bswap_{16,32,64} if there is a proper
> configure.in test for them.

The code does not compile anyway at least in mingw (I just tried) and 
probably in several other targets anyway.. with or without my patch :-)

I wonder *where* the developers of this other systems are and if they 
are willing to submit any improvement or fixes for the software.



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html