linux-ext4 - Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125033201.GD28908@thunk.org>
Date:	Thu, 24 Jan 2013 22:32:01 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole
 feature in fallocate

On Fri, Jan 18, 2013 at 03:16:21PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@...bao.com>
> 
> After adding indirect punching hole feature, we need to enable it in fallocate.
> For this purpose, some sanity checks need to be adjusted.  Currently we need to
> check FALLOC_FL_PUNCH_HOLE flag before other sanity checks.

I've folded these two patches into one since the first patch in this
series since there won't be any way to exercise the new code paths
until we enable this in fallocate(), and it doesn't really change
existing code paths.  If it did make huge changes in the normal code
path, it might be useful to keep the two commits separate, but that's
not the case here.

Anyway, they look good so I've checked them into my tree.  I'm
currently kicking off a test run to make sure there aren't any
problems except for the test 255 failure when testing w/o extents, but
I don't really anticipate any issues.

Thanks!!

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html