linux-ext4 - Re: [PATCH] Ext4: remove a useless check for the function ext4_data_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130126153826.GB5887@thunk.org>
Date:	Sat, 26 Jan 2013 10:38:26 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Wang Shilong <wangshilong1991@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Ext4: remove a useless check for the function
 ext4_data_block_valid

On Sat, Jan 26, 2013 at 02:57:59PM -0800, Wang Shilong wrote:
> From: Wang Shilong <wangsl-fnst@...fujitsu.com>
> 
> Because it is no doubt 'start_blk + count < start_blk' always comes to
> false. It is useless to have this check,remove it.

Actually, it can be true --- if start_blk + count (which are both
unsigned integers) overflows....

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html