linux-ext4 - Re: [PATCH, RFC V2] mke2fs: wipe out old btrfs superblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1301301036280.2669@dhcp-1-104.brq.redhat.com>
Date:	Wed, 30 Jan 2013 10:50:14 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Eric Sandeen <sandeen@...hat.com>
cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Karel Zak <kzak@...hat.com>
Subject: Re: [PATCH, RFC V2] mke2fs: wipe out old btrfs superblocks

On Tue, 29 Jan 2013, Eric Sandeen wrote:

> Date: Tue, 29 Jan 2013 11:10:49 -0600
> From: Eric Sandeen <sandeen@...hat.com>
> To: ext4 development <linux-ext4@...r.kernel.org>
> Subject: [PATCH, RFC V2] mke2fs: wipe out old btrfs superblocks
> 
> btrfs sticks superblocks at 64k, 64M, and 256G.  If we don't
> overwrite those, libblkid may accidentally identify an ext*
> filesystem with old btrfs superblocks as btrfs, and we'll
> be sad.
> 
> libblkid provides a blkid_wipe_fs() functionality to zero
> all existing signatures, but that'd break our handy-dandy
> undo capability, I think.  So I'm not sure we have any
> other choice but to do it ourselves.
> 
> There is a slight error here in that if the mkfs
> does not span the entire device, we won't overwrite
> signatures past the end of the filesystem, but that case
> should be pretty rare.  (The same slight error in logic
> applies to the existing "wipe old MD superblock" path).
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com
> Resolves-RHBZ: 902512
> ---

Hi Eric,

right we really need this functionality, but I think that we should
rather use blkid to wipe all the signatures.

Unfortunately as you already mentioned we have "undo" functionality
which makes things a little bit more complicated, because we can not
let blkid just wipe it for us. It should rather provide us the information
about the position of the signatures so we can wipe it of ourselves.

After the discussion with Karel Zak I think that the best approach
would be to blkid export blkid_probe_postwipe_reset() for us, so we
can walk the "chain" provided by blkid and do the actual wipe.

However it might be worth having this patch anyway since it solves
the situation right away without waiting for newer version of blkid
library.

btw. I have one comment bellow.

Thanks!
-Lukas

> 
> v2: skip this on "noaction"
> 
> I decided not to be tricky about previous zero-returning
> discards, there seems to be little point to that, we're
> just doing 3 IOs post discard, at worst.
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index bbf477a..0c67134 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -2307,6 +2307,32 @@ static int mke2fs_discard_device(ext2_filsys fs)
>  	return retval;
>  }
>  
> +static int mke2fs_wipe_btrfs(ext2_filsys fs)
> +{
> +	int blocks;	/* nr of blocks to zero */
> +	blk64_t start;	/* location to zero out */
> +	int retval = 0; /* accumulate any failures */
> +
> +	blocks = 1;
> +	if (fs->blocksize < 4096)
> +		blocks = 4096 / fs->blocksize;
> +	/*
> +	 * Wipe out any old btrfs superblocks, at
> +	 * 64k, 64M, and 256G.
> +	 */
> +	start = 64ULL * 1024 / fs->blocksize;
> +	retval += ext2fs_zero_blocks2(fs, start, blocks, NULL, NULL);
> +	start = 64ULL * 1024 * 1024 / fs->blocksize;
> +	if (start + blocks <= ext2fs_blocks_count(fs->super))
> +		retval += ext2fs_zero_blocks2(fs, start, blocks, NULL, NULL);
> +	start = 256ULL * 1024 * 1024 * 1024 / fs->blocksize;
> +	if (start + blocks <= ext2fs_blocks_count(fs->super))
> +		retval += ext2fs_zero_blocks2(fs, start, blocks, NULL, NULL);
> +	/* free the static zeroing buffer */
> +	ext2fs_zero_blocks2(0, 0, 0, 0, 0);
> +	return retval;
> +}
> +
>  static void fix_cluster_bg_counts(ext2_filsys fs)
>  {
>  	blk64_t	cluster, num_clusters, tot_free;
> @@ -2440,6 +2466,12 @@ int main (int argc, char *argv[])
>  		}
>  	}
>  
> +	if (!noaction) {
> +		retval = mke2fs_wipe_btrfs(fs);
> +		if (retval)
> +			printf(_("Failed to wipe old btrfs super locations\n"));
> +	}
> +

We might want to move the wipe after io_channel_set_options(). I am
not sure whether it will have any impact but since we'll be using
the io_channel I think it should be already set up.

>  	sprintf(tdb_string, "tdb_data_size=%d", fs->blocksize <= 4096 ?
>  		32768 : fs->blocksize * 8);
>  	io_channel_set_options(fs->io, tdb_string);
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html