linux-ext4 - Re: [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130206124612.GC6330@quack.suse.cz>
Date:	Wed, 6 Feb 2013 13:46:12 +0100
From:	Jan Kara <jack@...e.cz>
To:	Wang shilong <wangshilong1991@...il.com>
Cc:	jack@...e.cz, linux-ext4@...r.kernel.org,
	Wang Shilong <wangsl-fnst@...fujitsu.com>
Subject: Re: [PATCH 1/3] Ext2: remove the overhead check about sb in the
 function ext2_new_blocks

On Wed 06-02-13 14:14:26, Wang shilong wrote:
> From: Wang Shilong <wangsl-fnst@...fujitsu.com>
> 
> It can be guranteed that inode->i_sb should not be null in vfs.
> So here the check about it is overhead.
  This patch looks good. I've added it to my tree.

								Honza
> 
> Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
> ---
>  fs/ext2/balloc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index 1c36139..22993a0 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -1239,10 +1239,6 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
>  
>  	*errp = -ENOSPC;
>  	sb = inode->i_sb;
> -	if (!sb) {
> -		printk("ext2_new_blocks: nonexistent device");
> -		return 0;
> -	}
>  
>  	/*
>  	 * Check quota for allocation of this block.
> -- 
> 1.7.11.7
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html