linux-ext4 - [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1360131268-1615-1-git-send-email-wangshilong1991@gmail.com>
Date:	Wed,  6 Feb 2013 14:14:26 +0800
From:	Wang shilong <wangshilong1991@...il.com>
To:	jack@...e.cz
Cc:	linux-ext4@...r.kernel.org,
	Wang shilong <wangshilong1991@...il.com>,
	Wang Shilong <wangsl-fnst@...fujitsu.com>
Subject: [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks

From: Wang Shilong <wangsl-fnst@...fujitsu.com>

It can be guranteed that inode->i_sb should not be null in vfs.
So here the check about it is overhead.

Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
---
 fs/ext2/balloc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 1c36139..22993a0 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1239,10 +1239,6 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
 
 	*errp = -ENOSPC;
 	sb = inode->i_sb;
-	if (!sb) {
-		printk("ext2_new_blocks: nonexistent device");
-		return 0;
-	}
 
 	/*
 	 * Check quota for allocation of this block.
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html