linux-ext4 - Re: [PATCH] ext4: cleanup sbi->s_kobj after quota initialization failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGr1F2EjCa9Zm_TmMZtdXKO=GC5rrwusPJ4fwffHrtxVbpSyDA@mail.gmail.com>
Date:	Mon, 25 Feb 2013 17:14:26 -0800
From:	Aditya Kali <adityakali@...gle.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Jeff Mahoney <jeffm@...e.com>, "Theodore Ts'o" <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: cleanup sbi->s_kobj after quota initialization failure

This seems to have been fixed in the ext4 master branch by commit
http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=commitdiff;h=72ba74508b2857e71d65fc93f0d6b684492fc740


On Mon, Feb 25, 2013 at 3:32 PM, Jan Kara <jack@...e.cz> wrote:
> On Mon 25-02-13 15:55:23, Jeff Mahoney wrote:
>> If ext4_enable_quotas fails, it jumps to failed_mount7, which doesn't
>> tear down the kobj.
>   The patch looks good. You can add:
> Reviewed-by: Jan Kara <jack@...e.cz>
>
>                                                                 Honza
>
>> Cc: Aditya Kali <adityakali@...gle.com>
>> Cc: Jan Kara <jack@...e.cz>
>> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
>> ---
>>  fs/ext4/super.c |    6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -3794,7 +3794,7 @@ no_journal:
>>           !(sb->s_flags & MS_RDONLY)) {
>>               err = ext4_enable_quotas(sb);
>>               if (err)
>> -                     goto failed_mount7;
>> +                     goto failed_mount8;
>>       }
>>  #endif  /* CONFIG_QUOTA */
>>
>> @@ -3813,6 +3813,10 @@ cantfind_ext4:
>>               ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
>>       goto failed_mount;
>>
>> +failed_mount8:
>> +     kobject_del(&sbi->s_kobj);
>> +     kobject_put(&sbi->s_kobj);
>> +     wait_for_completion(&sbi->s_kobj_unregister);
>>  failed_mount7:
>>       ext4_unregister_li_request(sb);
>>  failed_mount6:
>>
>> --
>> Jeff Mahoney
>> SUSE Labs
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> Jan Kara <jack@...e.cz>
> SUSE Labs, CR



--

Aditya
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html