linux-ext4 - Re: [PATCH] ext4: optimize ext4_es

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130301162651.GB16485@thunk.org>
Date:	Fri, 1 Mar 2013 11:26:51 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Dave Jones <davej@...hat.com>
Cc:	"gnehzuil.liu" <gnehzuil.liu@...il.com>,
	Zheng Liu <wenqing.lz@...bao.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: optimize ext4_es_shrink()

On Fri, Mar 01, 2013 at 11:11:30AM -0500, Dave Jones wrote:
> On Fri, Mar 01, 2013 at 12:00:29AM -0500, Theodore Ts'o wrote:
>  > When the system is under memory pressure, ext4_es_srhink() will get
>  > called very often.  So optimize returning the number of items in the
>  > file system's extent status cache by keeping a per-filesystem count,
>  > instead of calculating it each time by scanning all of the inodes in
>  > the extent status cache.
>  > 
>  > Also rename the slab used for the extent status cache to be
>  > "ext4_extent_status" so it's obviousl the slab in question is created
>  > by ext4.
> 
> Seems to work with no ill effects afaics.

Thanks for reporting the problem and testing the fix!

I'll add a Reported-by: and Tested-by: Dave Jones <davej@...hat.com>
to the commit.  (Unless of course you have an objection, in which case
let me know.)

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html