linux-ext4 - Re: [PATCH] mke2fs: restore verbose message for BLKDISCARD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r4jpzm5g.fsf@octavius.laptop.org>
Date:	Fri, 08 Mar 2013 15:12:11 -0500
From:	Chris Ball <cjb@...top.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Theodore Ts'o <tytso@....edu>,
	Lukáš Czerner <lczerner@...hat.com>,
	linux-ext4@...r.kernel.org, Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH] mke2fs: restore verbose message for BLKDISCARD

Hi,

On Fri, Mar 08 2013, Stephen Warren wrote:
>> On Fri, Mar 08 2013, Theodore Ts'o wrote:
>>> I hate to suggest this, but there's so many crappy devices out there
>>> that I'm wondering if we need to figure out some way of maintaining a
>>> black list of devices that don't handle discard properly.
>> 
>> Yes, we already do that in the MMC layer.  See e.g.:
>> 
>> http://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?id=3550ccdb9d8d350e526b809bf3dd92b550a74fe1
>> ("mmc: card: Skip secure erase on MoviNAND; causes unrecoverable corruption.")
>
> Unrecoverable sounds scary. Does that just mean data corruption, or a
> permanently broken device? mk2e2fs -K followed by e2fsck and mounting
> luckily seems to still work OK for me:-)

Incredibly, it appears to cause a permanently broken device.  The URLs
in the commit message have some more details.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html