lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130311054707.GA3867@gmail.com> Date: Mon, 11 Mar 2013 13:47:07 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Theodore Ts'o <tytso@....edu> Cc: linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>, Dmitry Monakhov <dmonakhov@...nvz.org> Subject: Re: [PATCH v2 3/5] ext4: fix wrong m_len value after unwritten extent conversion On Sun, Mar 10, 2013 at 09:07:18PM -0400, Theodore Ts'o wrote: > On Wed, Mar 06, 2013 at 10:17:13PM +0800, Zheng Liu wrote: > > From: Zheng Liu <wenqing.lz@...bao.com> > > > > We always assume that the return value of ext4_ext_map_blocks is equal > > to map->m_len > > Note that in general, this is _never_ safe to assume. There are a > number of times when the number of blocks mapped is less than what the > caller originally requested, both when allocating blocks (and there > isn't the requestd number of contiguous blocks available), and when > EXT4_GET_BLOCKS_CREATE is not set. Yes, When EXT4_GET_BLOCKS_CREATE is not set, it could be 0 because there is no block mapping, and we don't create it. Meanwhile when we want to allocate some blocks, it could be less than the number of block we requested. But IMHO at least when we try to allocate some blocks, m_len should be changed according to the number of allocated blocks in order to make them equal if the number of allocated blocks is less than the number of blocks we requested. Namely, when the return value (retval) is greater than 0, this assumption will be right. Because we will use m_len value after map_blocks function returns. We need to let upper level know it, such as write_begin, DIO, etc... Am I miss something? Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists