linux-ext4 - Possible bug with extent status tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130311203834.GA22229@quack.suse.cz>
Date:	Mon, 11 Mar 2013 21:38:34 +0100
From:	Jan Kara <jack@...e.cz>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Possible bug with extent status tree

  Hello,

  while looking into the ext4 code I spotted one thing which I think is a
bug introduced by extent status tree code. The problem is that
ext4_map_blocks() checks extent status tree and if the extent is found, it
doesn't call into ext4_ext_map_blocks(). However ext4_ext_direct_IO() expects
that if the extent DIO is done to is unwritten, EXT4_IO_END_UNWRITTEN flag
gets set in the io_end (or inode) flags and that happens only in
ext4_ext_map_blocks().

The easiest fix seems to be to move setting of flags from
ext4_ext_map_blocks() up into ext4_map_blocks() (or maybe even
_ext4_get_block()). What do you think?

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html