linux-ext4 - [PATCH] Ext2: do not mark_inode_dirty to avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 13:06:37 +0800
From:	fanchaoting <fanchaoting@...fujitsu.com>
To:	jack@...e.cz
CC:	tyhicks@...onical.com, linux-ext4@...r.kernel.org,
	wangshilong1991@...il.com
Subject: [PATCH] Ext2: do not mark_inode_dirty to avoid BUG_ON

From: Wang Shilong <wangsl-fnst@...fujitsu.com>

commit 8e3dffc651cb668e1ff4d8b89cc1c3dde7540d3b leads into
a regression that casue BUG_ON when unlinking inode.

Reported-by: tyhicks@...onical.com
Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
---
 fs/ext2/balloc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 9f9992b..06d82fc 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -562,7 +562,6 @@ error_return:
 	if (freed) {
 		percpu_counter_add(&sbi->s_freeblocks_counter, freed);
 		dquot_free_block_nodirty(inode, freed);
-		mark_inode_dirty(inode);
 	}
 }
 
-- 1.7.7.6 




--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html