linux-ext4 - Re: [qrxd43@...orola.com: [PATCH V2] ext4: speed-up releasing blocks on commit]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Mar 2013 14:38:55 +0400
From:	Andrey Sidorov <qrxd43@...orola.com>
To:	Alex Tomas <bzzz.tomas@...il.com>
Cc:	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [qrxd43@...orola.com: [PATCH V2] ext4: speed-up releasing blocks
 on commit]

Hi Alex,

Thanks for review! I'll post rebased patch with comments and some
ascii art this weekend.

> the patch looks fine, the only suggestion is to move the following logic
> into mb_buddy_mark_free():
>
> + if (first & 1) {
> + first += !left_is_free;
> + e4b->bd_info->bb_counters[0] += left_is_free ? -1 : 1;
> + }
> + if (!(last & 1)) {
> + last -= !right_is_free;
> + e4b->bd_info->bb_counters[0] += right_is_free ? -1 : 1;
> + }

I didn't do that since buddy[0] is a special case since it is in fact
bd_bitmap itself. Moving that into mb_buddy_mark_free will make code
look worse because of this special handling. I think unrolling first
iteration that handles bd_bitmap looks much better.

Regards,
Andrey.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html