lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130327151922.GA4487@gmail.com> Date: Wed, 27 Mar 2013 23:19:22 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com> Subject: Re: [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate On Wed, Mar 27, 2013 at 11:07:35PM +0800, Zheng Liu wrote: > On Wed, Mar 27, 2013 at 09:51:55AM -0400, Theodore Ts'o wrote: > > Ah, now I see. Thanks for sending the stack trace. On the failure > > path, we're calling the inline function ext4_truncate_filaed_write() > > and this is calling ext4_truncate(). > > > > But I'm now wondering if we need to take the i_data_sem mutex in ^^^ Sigh, I misread i_data_sem and i_mutex. Really sorry about that. :-/ > > ext4_truncate_failed_write(). > > > > Otherwise, couldn't we end up with problems where a failed write calls > > ext4_truncate() without i_data_sem(), and that races with something > > else --- say, a punch or truncate call to that same inode? Let me think about it. I need to take a close look at it. Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists