linux-ext4 - Re: [PATCH 2/2] ext4: fix cpu_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130403160145.GB14991@thunk.org>
Date:	Wed, 3 Apr 2013 12:01:45 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>, linux-ext4@...r.kernel.org,
	wenqing.lz@...bao.com
Subject: Re: [PATCH 2/2] ext4: fix cpu_vs_disk conversions

On Wed, Apr 03, 2013 at 09:04:43PM +0800, Zheng Liu wrote:
> I agree with you that we need to fix the big-endian bug in extent tree
> because it affects all people who use ext4 file system.  Meanwhile I
> think we need to fix the problem in punching hole and xattr because that
> has been there.  I have looked at Dmitry's patch, and it fixes some
> problems that is only in dev branch (e.g. migration).  I think this
> problem can be fixed in 3.10 later.  Meanwhile metadata_csum is still
> under ext4dev.  So I think it also can be fixed in next merge window.

I took a closer look at the issues that Dmitry found in the checksum
code (including in xattr.c), and it doesn't actually fix any runtime
bugs.  It's mainly issues picked up by static code analyzers, but it's
not anything which is high priority to backport to stable kernels.

It's also the case that the zero_ex code was fine in 3.8; the bug
where we failed to introduce byte swapping was introduced in 3.9-rc1.

So the good news is that from what I can tell, there is no actual bug
leading to fs/data corruption relating to big endian systems in the
3.8.x kernels, and hence, the fixup patch will not need a
cc:stable@...r.kernel.org tag.

So what I am currently thinking about doing is fixing the actual bugs
(zero_ex and indirect punch hole) for 3.9-rc6.  The cleanup changes is
important so we can more easily find bugs using static code analyzers,
but that can be saved for the next merge window.  Sounds like a plan?

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html