linux-ext4 - Re: [PATCH] ext4: fixup 64-bit divides in linux-3.0 stable backport of upstream fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130405235509.GA13306@kroah.com>
Date:	Fri, 5 Apr 2013 16:55:09 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Todd Poynor <toddpoynor@...gle.com>, stable@...r.kernel.org,
	Lingzhu Xiang <lxiang@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fixup 64-bit divides in linux-3.0 stable backport
 of upstream fix

On Fri, Apr 05, 2013 at 07:50:18PM -0400, Theodore Ts'o wrote:
> Greg,
> 
> The reason why Todd's patch is needed in 3.0 is because the code in
> question was nuked as of 3.2 by commit 4113c4caa4f355:
> 
> commit 4113c4caa4f355b8ff8b7ff0510c29c9d00d30b3
> Author: Lukas Czerner <lczerner@...hat.com>
> Date:   Sat Oct 8 14:34:47 2011 -0400
> 
>     ext4: remove deprecated oldalloc
>     
>     For a long time now orlov is the default block allocator in the
>     ext4. It performs better than the old one and no one seems to claim
>     otherwise so we can safely drop it and make oldalloc and orlov mount
>     option deprecated.
>     
>     This is a part of the effort to reduce number of ext4 options hence the
>     test matrix.
>     
>     Signed-off-by: Lukas Czerner <lczerner@...hat.com>
>     Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> 
> So the 64-bit divides aren't in the upstream kernel because the code
> in question is long gone in the mainline ext4 code.  It looks like Cai
> (who did the 3.0 backport) never tested the patch on a 32-bit build.
> 
> Thanks Todd, for providing the patch.  You can add my:
> 
> Reviewed-by: "Theodore Ts'o" <tytso@....edu>
> 
> to it.  Greg, could you apply it to the stable tree?   Thanks!!

Thanks for the review, will apply it for the next release, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html