lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <51603877.7070904@gmail.com> Date: Sat, 06 Apr 2013 17:00:07 +0200 From: Marco Stornelli <marco.stornelli@...il.com> To: Matthew Wilcox <matthew@....cx> CC: linux-fsdevel@...r.kernel.org, Chris Mason <chris.mason@...ionio.com>, Alexander Viro <viro@...iv.linux.org.uk>, Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Jaegeuk Kim <jaegeuk.kim@...sung.com>, Steven Whitehouse <swhiteho@...hat.com>, KONISHI Ryusuke <konishi.ryusuke@....ntt.co.jp>, Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org>, Mike Snitzer <snitzer@...hat.com>, Alasdair G Kergon <agk@...hat.com>, linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com, linux-nilfs@...r.kernel.org, ocfs2-devel@....oracle.com, linux-mm@...ck.org, Jan Kara <jack@...e.cz> Subject: Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called Il 06/04/2013 15:20, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_pagefault was called now we must manage >> the error code and return VM_FAULT_RETRY. > > Erm ... in patch 1/4: > > static inline void sb_start_pagefault(struct super_block *sb) > { > - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true); > + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false); > } > >> >> - sb_start_pagefault(inode->i_sb); >> + ret = sb_start_pagefault(inode->i_sb); >> + if (ret) >> + return VM_FAULT_RETRY; >> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE); > > Does the compiler not warn that you're assigning void to 'ret'? Or was > there some other SNAFU sending these patches? > I'm sorry, my fault :) As I said in 00 these patches are completely *not* tested, it was only a "quick coding & review" to understand if someone can see any problem to this kind of implementation, since I touched several points in the kernel. So there is still on-going work and I need to do several tests. Maybe I had to add the RFC tag, sorry again. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists