linux-ext4 - Re: [PATCH] ext4: fix free space estimate in ext4_nonda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130409132819.GD12050@thunk.org>
Date:	Tue, 9 Apr 2013 09:28:19 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Whitney <enwlinux@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix free space estimate in ext4_nonda_switch()

On Wed, Apr 03, 2013 at 01:19:31PM -0400, Eric Whitney wrote:
> Values stored in s_freeclusters_counter and s_dirtyclusters_counter
> are both in cluster units.  Remove the cluster to block conversion
> applied to s_freeclusters_counter causing an inflated estimate of
> free space because s_dirtyclusters_counter is not similarly
> converted.  Rename free_blocks and dirty_blocks to better reflect
> the units these variables contain to avoid future confusion.  This
> fix corrects ENOSPC failures for xfstests 127 and 231 on bigalloc
> file systems.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Hi Eric,

This patch looks good.  Thanks for submitting it!!

I've applied it to the dev branch for testing.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html