linux-ext4 - Re: FYI: journal corruption after 305'th xfstest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d2u143lm.fsf@openvz.org>
Date:	Thu, 11 Apr 2013 17:08:21 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: FYI: journal corruption after 305'th xfstest

On Thu, 11 Apr 2013 10:53:23 +0400, Dmitry Monakhov <dmonakhov@...nvz.org> wrote:
> 
> I use recent ext4.git/dev head (9d35f846aa9ea)
> Looks like this is a regression.
Ok, nothing serious, just one more weird corner-case.
This is very old bug in generic error reporting.
After explicit error was triggered by fault injection knob
it mark blockdev with an error, but no one will clear it 
even after umount because (mapping->npages == 0)
which is true because kill_bdev() will cleanup a device mapping.

Later when we try to replay a journal on next mount we will discover
an error which happen long long time ago.

Fix is trivial and available here:https://lkml.org/lkml/2013/4/11/186
> 
> FSTYP         -- ext4
> PLATFORM      -- Linux/x86_64 sandy 3.9.0-rc5+
> MKFS_OPTIONS  -- -b1024 -O ^extents /dev/mapper/vzvg-scratch_dev
> MOUNT_OPTIONS -- -o acl,user_xattr /dev/mapper/vzvg-scratch_dev
> /mnt_scratch
> 
> shared/305       [failed, exit status 1] - output mismatch (see
> /root/xfstests-dev.git/results/shared/305.out.bad)
>     --- tests/shared/305.out    2013-04-09 15:53:12.000000000 +0400
>     +++ /root/xfstests-dev.git/results/shared/305.out.bad     2013-04-11
>     10:42:20.000000000 +0400
>     @@ -6,4 +6,5 @@
>      Start fio..
>      Force SCRATCH_DEV device failure
>      Make SCRATCH_DEV device operable again
>     -Disallow global fail_make_request feature
>     +failed: '_scratch_mount'
>     +(see /root/xfstests-dev.git/results/shared/305.full for details)
>      ...
>      (Run 'diff -u tests/shared/305.out
>      /root/xfstests-dev.git/results/shared/305.out.bad' to see the
>      entire diff)
> Ran: shared/305
> Failures: shared/305
> Failed 1 of 1 tests
> 
> Mount failed due to bad journal: EXT4-fs (dm-3): error loading journal
> last two commits in a journal:
> Found expected sequence 395, type 2 (commit block) at block 30358
> Found expected sequence 396, type 5 (revoke table) at block 30359
> Found expected sequence 396, type 1 (descriptor block) at block 30360
> Found expected sequence 396, type 1 (descriptor block) at block 30445
> Found expected sequence 396, type 1 (descriptor block) at block 30530
> Found expected sequence 396, type 1 (descriptor block) at block 30615
> Found expected sequence 396, type 1 (descriptor block) at block 30700
> Found expected sequence 396, type 1 (descriptor block) at block 30785
> Found expected sequence 396, type 1 (descriptor block) at block 30870
> Found expected sequence 396, type 2 (commit block) at block 30879
> Found expected sequence 397, type 5 (revoke table) at block 30880
> Found expected sequence 397, type 1 (descriptor block) at block 30881
> Found expected sequence 397, type 1 (descriptor block) at block 30966
> Found expected sequence 397, type 1 (descriptor block) at block 31051
> Found expected sequence 397, type 1 (descriptor block) at block 31136
> Found expected sequence 397, type 1 (descriptor block) at block 31221
> Found expected sequence 397, type 1 (descriptor block) at block 31306
> Found expected sequence 397, type 1 (descriptor block) at block 31391
> Found expected sequence 397, type 1 (descriptor block) at block 31476
> Found expected sequence 397, type 2 (commit block) at block 31500
> No magic number at block 31501: end of journal.
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html