linux-ext4 - Re: [PATCH -v3] ext4: move quota initialization out of inode allocation transaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130419162453.GA20513@thunk.org>
Date:	Fri, 19 Apr 2013 12:24:53 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH -v3] ext4: move quota initialization out of inode
 allocation transaction

On Fri, Apr 19, 2013 at 04:30:28PM +0200, Jan Kara wrote:
> > +	inode->i_flags |= S_NOQUOTA;
> > +	dquot_drop(inode);
>   The above two lines have to be swapped to preserve original ordering
> which is actually important. Thanks.
> 
> >  	iput(inode);

OK.  I'm confused --- what is the function of the S_NOQUOTA flag here?
I thought it was dquot_drop() which needed this magic flag set.  I can
swap these two lines, but maybe we should add a comment somewhere
about why this flag is needed and what the heck it's doing?  At this
point, the use of this flag seems like total magic to me.  :-(

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html