linux-ext4 - Re: [PATCH] ext4: disable defrag for metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130419061909.GB10053@thunk.org>
Date:	Fri, 19 Apr 2013 02:19:09 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Zheng Liu <gnehzuil.liu@...il.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: disable defrag for metadata_csum file systems

On Fri, Apr 19, 2013 at 02:17:27AM -0400, Theodore Ts'o wrote:
> On Thu, Apr 18, 2013 at 10:47:38PM -0700, Darrick J. Wong wrote:
> > 
> > I think this happens because mext_insert_extents() open-codes the metadata
> > dirtying and forgets to update the extent block header.  It should call
> > ext4_ext_dirty() at the end, instead. :(
> 
> Yes.  The following patch seems to fix the problem.

Ah, I see you posted a similar patch.  I'll take yours, since it's cleaner.

      	      	       	       	       	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html