linux-ext4 - Re: [PATCH] e2fsprogs: allow 0-length xattr values in e2fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130425042001.GA4685@thunk.org>
Date:	Thu, 25 Apr 2013 00:20:01 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	David Shaw <dshaw@...berwocky.com>,
	Harald Reindl <h.reindl@...lounge.net>
Subject: Re: [PATCH] e2fsprogs: allow 0-length xattr values in e2fsck

On Sun, Apr 07, 2013 at 01:42:18PM -0500, Eric Sandeen wrote:
> e2fsck thinks that this:
> 
> # touch mnt/testfile1
> # setfattr -n "user.test" mnt/testfile1
> 
> results in a filesystem with corruption:
> 
> Pass 1: Checking inodes, blocks, and sizes
> Extended attribute in inode 12 has a value size (0) which is invalid
> Clear? yes
> 
> but as far as I can tell, there is absolutely nothing wrong with
> a 0-length value on an extended attribute.  Just remove the check.
> 
> Reported-by: David Shaw <dshaw@...berwocky.com>
> Reported-by: Harald Reindl <h.reindl@...lounge.net>
> Addresses-Red-Hat-Bugzilla: #557959
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Thanks, applied.

It turns out that 0-length values applied for xattrs stored in
external xattr blocks.  0-length xattrs were only only getting
prohibited for in-inode xattrs.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html