linux-ext4 - Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E173CD13-2FD1-45A4-BEAE-815A9DEC4B62@dilger.ca>
Date:	Fri, 26 Apr 2013 17:09:28 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Josef Bacik <jbacik@...ionio.com>, linux-ext4@...r.kernel.org,
	xfs@....sgi.com
Subject: Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs

On 2013-04-26, at 1:18 PM, Eric Sandeen wrote:
> On 4/26/13 2:16 PM, Josef Bacik wrote:
>> mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk instead of just a partition, so any xfstest that uses a scratch device and you specify a full disk will appear to hang because it's waiting for you to say yes.  This fixes the problem by just forcing it to do its thing.  Thanks,
>> 
>> Signed-off-by: Josef Bacik <jbacik@...ionio.com>
> 
> Reviewed-by: Eric Sandeen <sandeen@...hat.com>
> 
> The whole-disk test is pretty derpy anyway. Too bad -F overrides
> much more than just that, but this is probably a decent
> thing to do.

Yeah, we've had to work around the whole-device check for years,
because the 512-byte sector offset for the DOS partition table
kills performance on RAID systems.

Given that the kernel should hold the whole block device busy these
days for O_EXCL opens if there are partitions on the device, it
should be safe to remove this check from mke2fs, though the above
workaround would still be needed for a while.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html