linux-ext4 - Re: [PATCH] ext4: remove unneeded call to ext4_es_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Apr 2013 13:28:09 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Ashish Sangwan <ashishsangwan2@...il.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org, wenqing.lz@...bao.com,
	Ashish Sangwan <a.sangwan@...sung.com>,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH] ext4: remove unneeded call to ext4_es_remove_extent in
 punch hole

On Sat, Apr 27, 2013 at 10:00:53AM +0530, Ashish Sangwan wrote:
> From: Ashish Sangwan <a.sangwan@...sung.com>
> 
> During punch hole, before removing extents we make sure that the blocks
> are commited to disk by calling filemap_write_and_wait_range. So, the
> extents cannot be present on extent status tree.
> 
> Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>

Hi Ashish,

I guess that this patch is against mainline kernel, right?  The commit
log is right before we use extent status tree to track all extent
information.  In dev branch of ext4 tree, we track all extent status in
status tree.  So we need to remove extent from status tree in punch
hole.

Thanks,
                                                - Zheng

> ---
>  fs/ext4/inode.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 50cced9..944eb15 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3749,13 +3749,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)
>  	down_write(&EXT4_I(inode)->i_data_sem);
>  	ext4_discard_preallocations(inode);
>  
> -	ret = ext4_es_remove_extent(inode, first_block,
> -				    stop_block - first_block);
> -	if (ret) {
> -		up_write(&EXT4_I(inode)->i_data_sem);
> -		goto out_stop;
> -	}
> -
>  	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
>  		ret = ext4_ext_remove_space(inode, first_block,
>  					    stop_block - 1);
> -- 
> 1.7.8.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html