linux-ext4 - Re: [PATCH 08/29] jbd2: Remove outdated comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130503142007.GB9564@gmail.com>
Date:	Fri, 3 May 2013 22:20:07 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 08/29] jbd2: Remove outdated comment

On Mon, Apr 08, 2013 at 11:32:13PM +0200, Jan Kara wrote:
> The comment about credit estimates isn't true anymore. We do what the
> comment describes now.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>
Regards,
                                                - Zheng

> ---
>  fs/jbd2/transaction.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 81df09c..74cfbd3 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -283,16 +283,6 @@ repeat:
>  	 * reduce the free space arbitrarily.  Be careful to account for
>  	 * those buffers when checkpointing.
>  	 */
> -
> -	/*
> -	 * @@@ AKPM: This seems rather over-defensive.  We're giving commit
> -	 * a _lot_ of headroom: 1/4 of the journal plus the size of
> -	 * the committing transaction.  Really, we only need to give it
> -	 * committing_transaction->t_outstanding_credits plus "enough" for
> -	 * the log control blocks.
> -	 * Also, this test is inconsistent with the matching one in
> -	 * jbd2_journal_extend().
> -	 */
>  	if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) {
>  		jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle);
>  		atomic_sub(nblocks, &transaction->t_outstanding_credits);
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html