linux-ext4 - Re: [PATCH] ext4: recalculate s_blockfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9D9D3649-7D5C-4755-B850-D87B5F5D3453@redhat.com>
Date:	Sun, 5 May 2013 23:31:21 -0400 (EDT)
From:	Eric Sandeen <esandeen@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>,
	Lachlan McIlroy <lmcilroy@...hat.com>
Subject: Re: [PATCH] ext4: recalculate s_blockfile_groups during resize2fs

On May 5, 2013, at 10:06 PM, "Theodore Ts'o" <tytso@....edu> wrote:

> On Fri, May 03, 2013 at 04:06:56PM -0500, Eric Sandeen wrote:
>> s_blockfile_groups is used to limit allocations for non-extent
>> files to block groups with block numbers less than 2^32.
>> However, it's not updated when the filesystem is resized online,
>> so the new groups are unavailable to non-extent files until a remount.
>> 
>> Fix this by updating the value in ext4_update_super() at
>> resize time.
>> 
>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> 
> I sent out a patch about two weeks ago, which has since been accepted
> into Linus's tree as commit c5c72d814cf0.  It's been marked for the
> for backporting into the stable trees.
> 
Argh, so you did!  One demerit for me for forgetting, and another for patching an old tree....

Thanks,
Eric

> Cheers,
> 
>                        - Ted
> 
> commit c5c72d814cf0f650010337c73638b25e6d14d2d4
> Author: Theodore Ts'o <tytso@....edu>
> Date:   Sun Apr 21 20:19:43 2013 -0400
> 
>    ext4: fix online resizing for ext3-compat file systems
> 
>    Commit fb0a387dcdc restricts block allocations for indirect-mapped
>    files to block groups less than s_blockfile_groups.  However, the
>    online resizing code wasn't setting s_blockfile_groups, so the newly
>    added block groups were not available for non-extent mapped files.
> 
>    Reported-by: Eric Sandeen <sandeen@...hat.com>
>    Signed-off-by: "Theodore Ts'o" <tytso@....edu>
>    Cc: stable@...r.kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html