linux-ext4 - Re: [PATCH v2] jbd2: Fix block tag checksum verification brokenness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4CE338D9-F69A-4568-AA82-012FEED2E252@dilger.ca>
Date:	Fri, 10 May 2013 23:18:18 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Theodore Ts'o <tytso@....edu>, Al Viro <viro@...IV.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v2] jbd2: Fix block tag checksum verification brokenness

On 2013-05-10, at 17:38, "Darrick J. Wong" <darrick.wong@...cle.com> wrote:
> static void jbd2_block_tag_csum_set(journal_t *j, journal_block_tag_t *tag,
> {
> 
> +    tag->t_checksum = cpu_to_be16(csum32);
> }

It wouldn't be a terrible idea to add a comment in these spots, since
it is a bit non-obvious to use cpu_to_be16() on a 32-bit variable. 

Cheers, Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html